Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way
removeClient
works in erizoJS.Before, when a Client left, erizoController would issue the commands to erizoJS to remove all published streams and subscriptions from that particular Client and then it would request the removal of the client itself. This approach lent itself to a number of race conditions.
With this PR, erizoController will only have to request the removal of the Client and only remove locally the data structures associated with that client (published and subscribed streams). ErizoJS will now process this removeClient as a command to remove the subscriptions and the published streams in the same operation.
The new
NodeManager
makes it easier for erizoJS to find published streams owned by a Client.Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc
.