Support for multiple simulcast configurations for published streams in one connection #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
reviewed
Jun 7, 2021
| } | ||
| stream.setSpatialLayersConfigs(spatialLayerConfigs); |
There was a problem hiding this comment.
I think this line should be out of the loop
jcague
reviewed
Jun 8, 2021
| log.debug(`message: Maybe set simulcast Layers config, simulcast: ${JSON.stringify(that.simulcast)}`); | ||
| if (streamInput.hasSimulcast() && streamInput.getSimulcastConfig().spatialLayerConfigs) { | ||
| streamInput.stream.transceivers.forEach((transceiver) => { | ||
| if (transceiver.sender.track.kind === 'video') { |
There was a problem hiding this comment.
I know this is not from this PR, but I've seen issues with Unified Plan because transceiver.sender can be null sometimes, can you add a check here to avoid issues?
|
Better version of this in #1726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves simulcast configuration from the Stacks to Streams. That allows for publishing multiple simulcast streams with different configurations in the same connection.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.