Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Simulcast Quality Layers #1723

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Jun 13, 2021

Description

Fixes an issue when configuring simulcast layers. It specially affects Screensharing.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 This looks good to me

numSpatialLayers = numSpatialLayers < totalLayers ?
numSpatialLayers : totalLayers;
const scaleResolutionDownBase = 2;
const scaleResolutionDownBaseScreenshare = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lodoyun lodoyun merged commit d460f3c into lynckia:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants