Implement target connection bandwidth #1736
Conversation
There was a problem hiding this comment.
LGTM!
I have a question: I understand that we can enable either it by calling setConnectionTargetBw(), by setting connectionTargetBw in the strategy, or by passing it as an option when publishing or subscribing the first stream, am I right? I'm not sure I like the third option.
And I guess that the last API that is called updates the value, with no other preference or relationship between APIs.
I like having it
| @@ -183,6 +186,7 @@ int64_t RtpPaddingManagerHandler::getTotalTargetBitrate() { | |||
| } | |||
| target_bitrate += media_stream->getTargetVideoBitrate(); | |||
| }); | |||
| target_bitrate = std::max(target_bitrate, static_cast<int64_t>(connection_->getConnectionTargetBw())); | |||
| @@ -23,6 +23,7 @@ class Client extends EventEmitter { | |||
| this.ioThreadPool = ioThreadPool; | |||
| this.singlePc = singlePc; | |||
| this.streamPriorityStrategy = Client._getStreamPriorityStrategy(streamPriorityStrategy); | |||
| this.connectionTargetBw = options.connectionTargetBw || 0; | |||
There was a problem hiding this comment.
I'm not sure I like this third way of adding it. Shouldn't we obtain the value from the streamPriorityStrategy?
this.connectionTargetBw = this.streamPriorityStrategy.connectionTargetBw;There was a problem hiding this comment.
The value may have been updated, erizoController sends the last version with every addPublisher or addSubscriber. Here we're accounting for the case where this client was not present in this erizoJS
Description
This PR implements a way to set a
target bandwidthfor connections in Licode. This target can be set with as part of a strategy asconnectionTargetBwor by callingroom.setConnectionTargetBandwidthin the client.The main use of target bitrate is to provide a goal or a target for the bandwidth estimation. Licode will generate padding to try to reach the target bitrate.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.