Add moving average stats #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Mar 6, 2017
erizo/src/erizo/stats/StatNode.cpp
Outdated
|
|
||
| // if now is in the middle of an interval | ||
| // add the proportional part of the current interval | ||
| double interval_part = static_cast<double>((now_ms - (calculation_start_ms_ + |
There was a problem hiding this comment.
please consider calculating interval_part in another method, something like getCurrentIntervalProportion(now_ms);
erizo/src/erizo/stats/StatNode.cpp
Outdated
| } | ||
| int32_t intervals_to_pass = ((now_ms - real_interval) - | ||
| (calculation_start_ms_ + available_window * interval_size_ms_) * interval_size_ms_) / interval_size_ms_; | ||
| intervals_to_pass = intervals_to_pass < 0 ? 0 : intervals_to_pass; // can be less than zero in first value |
There was a problem hiding this comment.
consider intervals_to_pass = std::max(intervals_to_pass, 0);
erizo/src/erizo/stats/StatNode.cpp
Outdated
| } | ||
|
|
||
| uint64_t now_ms = ClockUtils::timePointToMs(clock_->now()); | ||
| // We check if it's within the data we have |
There was a problem hiding this comment.
prefer moving logic to other self-explained methods vs adding comments
erizo/src/erizo/stats/StatNode.cpp
Outdated
| uint64_t now_ms = ClockUtils::timePointToMs(clock_->now()); | ||
| // We check if it's within the data we have | ||
| uint32_t available_window = std::min(accumulated_intervals_, static_cast<uint64_t>(intervals_in_window_)); | ||
| uint64_t min_requested_ms = std::max((now_ms - interval_to_calculate_ms), |
There was a problem hiding this comment.
please consider removing some parentheses:
uint64_t min_requested_ms = std::max(now_ms - interval_to_calculate_ms,
calculation_start_ms_ + (accumulated_intervals_ - available_window) * interval_size_ms_);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two new types of stats:
-MovingIntervalRateStat: A new RateStat that can be configured with an interval size and the number of intervals to track. It can also calculate the rate for the whole window or a partial rate from the last n ms
Add a short description here, please.
[X] It needs and includes Unit Tests
Changes in Client or Server public APIs
None.
Add a detailed description of any change in the public APIs.
[] It includes documentation for these changes in
/doc.