Add a padding generator handler #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Mar 9, 2017
| } | ||
|
|
||
| void RtpPaddingGeneratorHandler::read(Context *ctx, std::shared_ptr<dataPacket> packet) { | ||
| RtpUtils::forEachRRBlock(packet, [this](RtcpHeader *chead) { |
There was a problem hiding this comment.
I'm thinking we should move as much as we can to the stats. Here it makes sense to react as soon as we get the info but I keep thinking we should avoid parsing the same packets n times.
| } | ||
| first_packet_received_ = true; | ||
| if (fast_start_ && clock_->now() - started_at_ > kFastStartMaxDuration) { | ||
| ELOG_WARN("Fast start disabled"); |
There was a problem hiding this comment.
See log level comment above
There was a problem hiding this comment.
good catch! I used those while testing it manually
| } | ||
| } else if (fast_start_ && chead->packettype == RTCP_Receiver_PT && chead->getSourceSSRC() == audio_source_ssrc_) { | ||
| if (chead->getFractionLost() > kMaxFractionLostAllowed) { | ||
| ELOG_WARN("Fast start disabled"); |
There was a problem hiding this comment.
Probably DEBUG or INFO would be better here
| @@ -59,3 +59,4 @@ log4j.logger.rtp.SenderBandwidthEstimationHandler=WARN | |||
| log4j.logger.rtp.StatsCalculator=WARN | |||
| log4j.logger.rtp.LayerDetectorHandler=WARN | |||
| log4j.logger.rtp.PliPacerHandler=WARN | |||
| log4j.logger.rtp.RtpPaddingGeneratorHandler=WARN | |||
There was a problem hiding this comment.
Can you please also add this to the tests log4cxx.properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of Simulcast/SVC it adds a new handler to generate padding. It will be useful when we need to increase bitrates and sender bandwidth estimations.
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.