Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a SegFault when reading from closed connections #804

Merged

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Mar 15, 2017

Description

It could fix #793 when reading data while closing connections.

@shahrukh330 can you please try this PR? I think it could fix the crash you found.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution. 👍

@jcague jcague mentioned this pull request Mar 16, 2017
@jcague jcague merged commit cb5207f into lynckia:master Mar 28, 2017
@jcague jcague deleted the fix/segfault_when_reading_from_closed_connections branch March 28, 2017 06:27
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErizoJs crash
2 participants