Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable padding when max layer is 0/0 #820

Merged

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Mar 22, 2017

Description

Disable padding when max layer is 0/0 to avoid introducing padding when there is no simulcast/svc.
Also added a utility method to enable/disable padding
[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could probably be more conservative with padding even in Simulcast.

@lodoyun lodoyun merged commit 1bd84a6 into lynckia:master Mar 23, 2017
@lodoyun lodoyun deleted the fix/DisablePaddingWhenNoLayersAvailable branch March 23, 2017 09:21
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants