Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed padding remove implementation #841

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Fixed padding remove implementation #841

merged 2 commits into from
Apr 7, 2017

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Apr 6, 2017 •
edited
Loading

Description

Fixed padding removal in the publisher. It was not properly throwing away full padding packets

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

  • It includes documentation for these changes in /doc.

@JasonBenn
Copy link

(The markdown for checkboxes is - [ ])

jcague
jcague approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@lodoyun lodoyun merged commit 10283a2 into lynckia:master Apr 7, 2017
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@lodoyun
Fixed padding remove implementation (lynckia#841)
97964a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lodoyun @JasonBenn @jcague