Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker push with multiple tags #981

Merged
merged 2 commits into from
Jul 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ jobs:
docker login -u ${DOCKER_USER} -p ${DOCKER_PASS}
echo Tagging to lynckia/licode:${SHORT_GIT_HASH}
docker tag lynckia/licode:develop lynckia/licode:${SHORT_GIT_HASH}
docker push lynckia/licode:develop lynckia/licode:${SHORT_GIT_HASH}
docker push lynckia/licode:develop
docker push lynckia/licode:${SHORT_GIT_HASH}
fi

prerelease:
Expand Down
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
.project
.cproject
.git
.circleci
licode_config.js
rtp_media_config.js
utils/release.sh
Expand Down
6 changes: 4 additions & 2 deletions utils/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ if [ "$MODE" = "PRERELEASE" ]; then
# Tag with minor version and staging
docker tag lynckia/licode:${SHORT_GIT_HASH} lynckia/licode:${NEXT_PRERELEASE_NAME}
docker tag lynckia/licode:${SHORT_GIT_HASH} lynckia/licode:staging
docker push lynckia/licode:${NEXT_PRERELEASE_NAME} lynckia/licode:staging
docker push lynckia/licode:${NEXT_PRERELEASE_NAME}
docker push lynckia/licode:staging

LOGS=`git log $PREVIOUS_VERSION..$COMMIT --oneline | perl -p -e 's/\n/\\\\n/'`
DESCRIPTION="### Detailed PR List:\\n$LOGS"
Expand Down Expand Up @@ -108,7 +109,8 @@ elif [ "$MODE" = "RELEASE" ]; then
# Tag with minor version and staging
docker tag lynckia/licode:${LATEST_PRERELEASE_NAME} lynckia/licode:${RELEASE_NAME}
docker tag lynckia/licode:${LATEST_PRERELEASE_NAME} lynckia/licode:latest
docker push lynckia/licode:${RELEASE_NAME} lynckia/licode:latest
docker push lynckia/licode:${RELEASE_NAME}
docker push lynckia/licode:latest

# TODO(javier): Remove lynckia/licode:XXX that belongs to this release

Expand Down