Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from mozilla's repo #6

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

vpoddubchak
Copy link

Actual for 30-Mar-2021

docfaraday and others added 26 commits March 30, 2021 16:32
…x a bug where handling of teredo and mac-based IPv6 was mixed up. r=mjf

Differential Revision: https://phabricator.services.mozilla.com/D76042
… be marked as temporary, and filter non-temp IPv6 if temp IPv6 are available. r=mjf

Differential Revision: https://phabricator.services.mozilla.com/D76043
… because the latter does not work properly on FreeBSD. r=mjf

Differential Revision: https://phabricator.services.mozilla.com/D78319
…tand. r=mjf

Includes removing an error code for a function that never fails, and removing
an error return when the function successfully did what it said it would.

Differential Revision: https://phabricator.services.mozilla.com/D78929
… just in case that candidate fails immediately. r=drno

Differential Revision: https://phabricator.services.mozilla.com/D97701
…teardown. r=mjf

Also some improvements in discipline wrt bare pointers.

Differential Revision: https://phabricator.services.mozilla.com/D97016
…hat LoadInfo's CookieJarSettings for our DNS/proxy lookup, and remove a flag that was breaking http proxy support for webrtc. r=timhuang,mjf

Differential Revision: https://phabricator.services.mozilla.com/D99362
…s to the socket class, instead of using nr_resolver. r=mjf

* Modified nr_transport_addr to allow it to represent an
  fqdn/ip-version/protocol tuple, and taught nICEr to handle the
  fqdn case appropriately.
* Since nr_transport_addr can represent an fqdn, nr_ice_stun_server
  did not need this ability anymore, and was significantly simplified.
* Taught NrIceCtx to handle creation of a V4/V6 pair of nr_ice_stun_server
  when an fqdn is used, instead of having nICEr create pairs later.

Depends on D101657

Differential Revision: https://phabricator.services.mozilla.com/D101658
…DNSStunBogusHostnameTcp

Backed out changeset cf60a787b5ad (bug 1416220)
Backed out changeset 8e9a13c508c6 (bug 1416220)
Backed out changeset 8720dfa5a6e0 (bug 1416220)
Backed out changeset d4cadef3d55d (bug 1416220)
Backed out changeset d6ec5692e05e (bug 1416220)
Backed out changeset a2069e46d965 (bug 1416220)
…s to the socket class, instead of using nr_resolver. r=mjf

* Modified nr_transport_addr to allow it to represent an
  fqdn/ip-version/protocol tuple, and taught nICEr to handle the
  fqdn case appropriately.
* Since nr_transport_addr can represent an fqdn, nr_ice_stun_server
  did not need this ability anymore, and was significantly simplified.
* Taught NrIceCtx to handle creation of a V4/V6 pair of nr_ice_stun_server
  when an fqdn is used, instead of having nICEr create pairs later.

Differential Revision: https://phabricator.services.mozilla.com/D101658
* Allow nr_resolver to be used for TCP when not running in e10s/socket process mode.
* Init IPv6 STUN/TURN servers appropriately.
* Fix bug that was preventing STUN server hostname from being configured.
* Disable some tests that relied on STUN TCP that hasn't been available for a long time.
  (This went unnoticed due to the previous problem)
* A small logging improvement.

Depends on D101660

Differential Revision: https://phabricator.services.mozilla.com/D103332
@vpoddubchak
Copy link
Author

This will require little changes in NicerIntarface because they changed interface a bit.

…n functions. r=mjf

Also, some logging that was useful.

Depends on D110634

Differential Revision: https://phabricator.services.mozilla.com/D110635
…r=mjf

This substantially simplifies the task of replacing the nr_socket a TURN
context is using.

Differential Revision: https://phabricator.services.mozilla.com/D115281
Making this part of the stack for bug 857668, since it avoids adding even more
const casting there.

Differential Revision: https://phabricator.services.mozilla.com/D115282
docfaraday and others added 12 commits August 6, 2021 11:37
STUN/300 is only meaningful for specific STUN method types, and the handling
depends on the spec that those methods are defined in. Doing any handling in
the base stun client code is not appropriate.

Differential Revision: https://phabricator.services.mozilla.com/D115285
Also some logging that was useful in debugging this.

Differential Revision: https://phabricator.services.mozilla.com/D115287
Nothing used this function before this bug, so this field has never been used
anyway. We handle challenge loops with nr_turn_stun_ctx.retry_ct.

Differential Revision: https://phabricator.services.mozilla.com/D115293
We only use this with TCP sockets.

Depends on D115293

Differential Revision: https://phabricator.services.mozilla.com/D115829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants