allow only one confirmation

[MaicolBen]

Reopened #519 because it has conflicts and the original author can't rebase it

Thanks @rmvenancio !

[olleolleolle]

Thank you for bringing this to a mergeable PR.

[olleolleolle]

Perhaps a space after the operator?

[hansy]

This change means sign_in_count is a required attribute for the confirmable module? Doesn't Devise add errors to the instance if it's already been confirmed? If so, wouldn't it make more sense for the confirmations controller to check for errors on the resource before proceeding to generate headers and/or sign it in?

[zachfeldman]

@hansy if this is concerning for you please file a new issue since this was already merged! Thanks

[MaicolBen]

@hansy It was fixed in #1064

[Evan-M]

The #assert method from minitest does not yield the block that is given here!
(See RDoc for Minitest::Assertions#assert)

To further demonstrate this, even with an exception raised from within the block, the test still passes!

test 'user already confirmed' do
  assert @resource.sign_in_count > 0 do
    assert expiry == (Time.now + Time.now + 1.second).to_i
    raise "Chunky Bacon!"
  end
end

[Evan-M]

n/m... I commented here waaay late, and this has been resolved by #1113.