Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirmation should redirect to default_confirm_success_url by default #1091

Merged
merged 1 commit into from
Sep 8, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/controllers/devise_token_auth/confirmations_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,15 @@ def show
redirect_headers = build_redirect_headers(token,
client_id,
redirect_header_options)
redirect_to(@resource.build_auth_url(params[:redirect_url],
redirect_headers))

# give redirect value from params priority
@redirect_url = params[:redirect_url]

# fall back to default value if provided
@redirect_url ||= DeviseTokenAuth.default_confirm_success_url


redirect_to(@resource.build_auth_url(@redirect_url, redirect_headers))
else
raise ActionController::RoutingError.new('Not Found')
end
Expand Down