Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a reset password message in Japanese locales. #1241

Conversation

seigo23
Copy link
Contributor

@seigo23 seigo23 commented Nov 30, 2018

Japanese locales has a small problem in devise_token_auth/config/locales/ja.yml

This 'request_reset_link_msg' is "下記のリンクからパスワードの変更 'を' できます" right now.

But this message is slightly strange for Japanese.

In this case, "下記のリンクからパスワードの変更 'が' できます". is natural.

This is very small problem,
But this message could be seen by users who use the web service.

And, Japanese are often suspicious of that web service if some messages has strange Japanese grammar.

ex.
"Was this web service developed by a dishonest dealer...??
I don't want to use that service, because
there is a possibility to get some computer virus from that service...."

So, I make a suggestion fixing this small grammatical mistakes.

Copy link
Collaborator

@MaicolBen MaicolBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix, and great example! Use G Translator and makes sense

@MaicolBen MaicolBen merged commit 7e6d853 into lynndylanhurley:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants