replace deprecated constant BLACKLIST_FOR_SERIALIZATION #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the specs? Maybe we need to upgrade devise |
update devise version
|
@prashant-kiwi you need some help with the tests man? |
@MaicolBen @ThiagoAnunciacao I have fixed the specs. Please have a look. |
MaicolBen
reviewed
Mar 24, 2021
There was a problem hiding this comment.
I think we need to have both behaviors and check if the new variable is defined, we cannot leave a lot of people behind for this. Sorry because I said "maybe we need to upgrade to devise" I didn't think is was that big upgrade. Leaving people behind isn't the solution unless we are talking about a very hard change or it's a critical security upgrade
MaicolBen
approved these changes
Mar 28, 2021
wangzuo
pushed a commit
to wangzuo/devise_token_auth
that referenced
this pull request
Mar 30, 2021
…ley#1473) * replace deprecated constant BLACKLIST_FOR_SERIALIZATION * update devise version * updated devise gem * change devise gem version in all gemfiles * Add condition to check if constant is available in devise Co-authored-by: prashantchauhan627 <prashantchauhan627@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the constant BLACKLIST_FOR_SERIALIZATION with UNSAFE_ATTRIBUTES_FOR_SERIALIZATION.