Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback if migrations fails #1502

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Fix callback if migrations fails #1502

merged 1 commit into from
Nov 6, 2021

Conversation

thooams
Copy link
Contributor

@thooams thooams commented Sep 2, 2021 •
edited
Loading

To prevent failed migration, when you insert this gem in existing project and you want to run:

rake db:create && rake db:migrate

Migrations fail because of uid and provider attributes that do not exist yet in the first migrations (past migrations).

MaicolBen
MaicolBen reviewed Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@MaicolBen MaicolBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain your change?

app/models/devise_token_auth/concerns/user_omniauth_callbacks.rb Show resolved Hide resolved
@thooams
Copy link
Contributor Author

thooams commented Sep 16, 2021

Can you explain your change?
I edited my first comment.

@thooams
Copy link
Contributor Author

thooams commented Oct 18, 2021

Someone wants to merge this PR ?

@thooams thooams requested a review from MaicolBen November 4, 2021 16:03
MaicolBen
MaicolBen approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@MaicolBen MaicolBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thooams Thanks, sorry for the delay, it's weird handling this case but it makes sense

@MaicolBen MaicolBen merged commit 2fed895 into lynndylanhurley:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaicolBen MaicolBen MaicolBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thooams @MaicolBen