🐛 Not update cookies when is a batch request #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djpremier can you rebase to make sure tests pass? |
Hi Maicol, yes, one a moment. |
djpremier
force-pushed
the
security/dont-change-cookies-on-batch-requests
branch
from
4e64ffd to
aaf25c0
Compare
|
one spec fails 😞 |
djpremier
force-pushed
the
security/dont-change-cookies-on-batch-requests
branch
from
aaf25c0 to
0bdae2e
Compare
|
Hi @MaicolBen, now all tests work! 🎉 (I suspect it was |
ThiagoAnunciacao
pushed a commit
to ThiagoAnunciacao/devise_token_auth
that referenced
this pull request
Jul 6, 2023
* 🐛 Not update cookies when is a batch request * ✅ Fix confirmations controller test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the batch requests approach, when this occurs the header has a blank token for the other requests and with that the current logic invalidates the cookie, as it is automatically updated by the back-end without any control from the client (browser) , for those cases due to ignore any change in them to keep what was received in the last valid request (in theory the first received that was not treated as a batch).