fix(email-validation): Update in-use email validation message during registration to allow full_message use #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge during registration to allow full_message use Currently, if you have an email validation error during registration, you get a `full_message` response of "Email This Email address is already in use" and so you cannot simply regurgitate that as a client-facing error. This is because `full_message` construction takes the field name and prepends it to the default devise messaging. While this commit results in more abbreviated messaging, it allows `full_messages` to be used across the board without any additional programmatic work. If this message is not ideal, I believe it can still be modified through devise translation configuration: http://stackoverflow.com/a/12435725/824966
booleanbetrayal
added a commit
that referenced
this pull request
Jun 16, 2015
fix(email-validation): Update in-use email validation message during registration to allow full_message use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you have an email validation error during registration, you get a
full_messageresponse of "Email This Email address is already in use" and so you cannot simply regurgitate that as a client-facing error. This is becausefull_messageconstruction takes the field name and prepends it to the default devise messaging.While this commit results in more abbreviated messaging, it allows
full_messagesto be used across the board without any additional programmatic work. If this message is not ideal, I believe it can still be modified through devise translation configuration: http://stackoverflow.com/a/12435725/824966