Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid omniauth redirect #322

Merged
merged 2 commits into from
Aug 11, 2015

Conversation

troggy
Copy link
Contributor

@troggy troggy commented Jul 29, 2015

Addresses issue #285

@booleanbetrayal
Copy link
Collaborator

Thanks for this PR @troggy, but we shouldn't be using File.join since the separator isn't guaranteed to be the same across environments. Can you refactor to use vanilla string concatenation instead?

@c0mrade
Copy link

c0mrade commented Jul 29, 2015

👍

@booleanbetrayal
Copy link
Collaborator

@c0mrade - between you and @troggy , whoever gets me a PR for this (without the File.join and preferably with a test) wins! =]

@troggy
Copy link
Contributor Author

troggy commented Aug 1, 2015

Like this?

@c0mrade
Copy link

c0mrade commented Aug 11, 2015

@booleanbetrayal is this good what troggy did?

booleanbetrayal added a commit that referenced this pull request Aug 11, 2015
@booleanbetrayal booleanbetrayal merged commit 72243c7 into lynndylanhurley:master Aug 11, 2015
@booleanbetrayal
Copy link
Collaborator

Thanks! Got lost in the shuffle of a cross-country move. =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants