Use resource_class to override email confirmation. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @edgarhenriquez! I'll review this and merge ASAP! |
|
Good catch! Thanks @edgarhenriquez!!! |
lynndylanhurley
added a commit
that referenced
this pull request
Nov 10, 2014
…ail-confirmation Use resource_class to override email confirmation.
edgarhenriquez
deleted the
use-resource-class-to-override-email-confirmation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lynndylanhurley,
If you try to use devise_token_auth without a defined User class, you'll get a:
because the
User.skip_callback("create", :after, :send_on_create_confirmation_instructions).I changed it to use the generic
resource_classand ran the test suite according to your instructions here.I didn't add any test because I believe this change is related to d56af20, but let me know if I should add the test for it.
Thanks