Conditionally set rails version on migration #737
Conversation
When the user follows the confirmation link with success, he automatically sign in to the system. The information about the number of sign in, the ip etc is not recorded in the database. This change allows this information to be saved to the database.
…ause-app-to-connect-to-db Better implementation to test if connection to db is active
References lynndylanhurley#944
…ss_url Docs - add confirm_sucess_url to required params in email registration
…in_providers Allow other provider than email when logins
Use rails validator instead of custom one
Improve documentation for testing.
…ub-issues-template GitHub Issues template, Contributing guidelines
- [ci skip] - Add headings - Bold type some things - Clarify
CONTRIBUTING: Add header, format sections
The `confirm_success_url` param is compulsory for registering a new user. Add mention in the corresponding API endpoint, beside `email`, `password` and `password_confirmation`.
|
Makes sense to me but the build fails. @akz92 could you look into this? We will close in 7 days if we don't hear from you but just let us know if you need more time! |
…irm_success_url Document the confirm_success_url param for email registration
…e-authorized_users_only_error-response Feature/customable authorized users only error response
…lifespans Allow user specific token lifespans
…rect-url Support setting whitelist, without setting default redirect_url
…ibutors-wanted Add a call to contribute to the top of the README. Ref lynndylanhurley#969.
Always set header in batch mode
Fix header name on account delete documentation
Flag signin when user confirms email address.
|
@akz92 I reproduced the issue and your PR solves it. I believe travis failing due to an old build that was wrongly merged. Can you rebase it? Otherwise if we don't hear from you in a week. I will cherry-pick this PR and do it myself. |
|
@MaicolBen I rebased it but apparently something is still wrong. It's been a long time since I created the pull request, so it would take me some time to figure this out =/. |
|
Weird, maybe because you did it from master. I guess you should force push your master with lastest code of this gem and add your commit |
|
I recreated the PR #979 since we didn't hear from you, thanks anyway!! |
I added a condition that only appends the Rails version to the migration if it's 5 or greater (when this syntax was added). This code was causing issues when running the migration on Rails 4.