Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for devise 4.3 that is now supporting rails 5.1 #891

Merged
merged 3 commits into from
May 17, 2017
Merged

Support for devise 4.3 that is now supporting rails 5.1 #891

merged 3 commits into from
May 17, 2017

Conversation

silviusimeria
Copy link
Contributor

Issue #875

@edwardmp
Copy link

Was just creating something similar, thanks. @lynndylanhurley could you merge this in asap please?

@booleanbetrayal booleanbetrayal merged commit 7659cc2 into lynndylanhurley:master May 17, 2017
@booleanbetrayal booleanbetrayal mentioned this pull request May 17, 2017
Closed
@mvz
Copy link

mvz commented May 18, 2017

Please consider changing the Devise dependency so that you won't have to change it when Devise 4.3.1 comes out. E.g., use < 4.4.

@edwardmp
Copy link

@mvz that sounds like a good idea

@silviusimeria
Copy link
Contributor Author

@mvz @edwardmp Using < 4.4 might have been better indeed. I doubt a new version of Devise will be released soon, though.

@booleanbetrayal
Copy link
Collaborator

Just bumped this to < 4.4 in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silviusimeria @edwardmp @mvz @booleanbetrayal