Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use ngCookie instead of the standard ngCookies? #71

Closed
bahoo opened this issue Dec 2, 2014 · 1 comment
Closed

Why use ngCookie instead of the standard ngCookies? #71

bahoo opened this issue Dec 2, 2014 · 1 comment

Comments

@bahoo
Copy link

bahoo commented Dec 2, 2014

Any reason? Just curious.

Might also be nice to not make ngCookie a dependency since I'm using localStorage instead of cookies, but that might not play cleanly with Bower, etc.

Thanks!

Jon

@lynndylanhurley
Copy link
Owner

@bahoo - see #63, and also angular/angular.js#1786.

The short version is that it's impossible to control the path value of the cookie, and it results in duplicate auth tokens. The only options were to re-implement cookie storage from scratch, or to use the ipCookie module. The ipCookie module seemed like the better choice, and it's been working well so far.

About the cookie module dependency, I'm not sure how to set optional dependencies with bower. I need the module for the test build, so I had to include it in the deps.

nbrustein pushed a commit to nbrustein/ng-token-auth that referenced this issue May 27, 2015
…nsensitive_email_registration

fix(registration and update): Ensure UID is updated alongside Email, and case-sensitivity is honored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants