Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Add MoveGenerator.CanGenerateAtLeastAValidMove #360

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Aug 18, 2023

Add MoveGenerator.CanGenerateAtLeastAValidMove to check move validity on the fly instead of generating all moves first

We use this in NegaMax to see if we can trigger QSearch and to validate the outcome in case no best move is found during QSearch

Score of Lynx 1291 - hasvalidmoves vs Lynx 1287 - main: 1108 - 934 - 666  [0.532] 2708
...      Lynx 1291 - hasvalidmoves playing White: 644 - 370 - 339  [0.601] 1353
...      Lynx 1291 - hasvalidmoves playing Black: 464 - 564 - 327  [0.463] 1355
...      White vs Black: 1208 - 834 - 666  [0.569] 2708
Elo difference: 22.4 +/- 11.4, LOS: 100.0 %, DrawRatio: 24.6 %
SPRT: llr 2.95 (100.3%), lbound -2.94, ubound 2.94 - H1 was accepted

…ty on the fly instead of generating all moves first

We use this in NegaMax to see if we can trigger QSearch and to validate the outcome in case no best move is found during QSearch
@eduherminio eduherminio marked this pull request as ready for review August 19, 2023 11:12
@eduherminio eduherminio enabled auto-merge (squash) August 19, 2023 11:12
@eduherminio eduherminio merged commit 872471c into main Aug 19, 2023
18 checks passed
@eduherminio eduherminio deleted the perf/movegen/hasvalidmoves branch August 19, 2023 11:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant