Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Move eval to TunableEvalParameters file and make it non tunable via appsettings #889

Merged
merged 4 commits into from
Aug 3, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Aug 3, 2024

Related to #850

Before the revert:

Test  | cleanup/move-eval-to-separated-file-2-eval-terms
Elo   | -3.77 +- 3.79 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.29 (-2.25, 2.89) [-3.00, 1.00]
Games | 15566: +4666 -4835 =6065
Penta | [511, 1814, 3282, 1685, 491]
https://openbench.lynx-chess.com/test/521/

After:

Test  | cleanup/move-eval-to-separated-file-2-eval-terms
Elo   | -2.92 +- 3.24 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.26 (-2.25, 2.89) [-3.00, 1.00]
Games | 21144: +6378 -6556 =8210
Penta | [694, 2411, 4508, 2297, 662]
https://openbench.lynx-chess.com/test/526/

Merging anyway to keep everything in the same file, at least temporarily

@eduherminio eduherminio marked this pull request as ready for review August 3, 2024 02:11
@eduherminio eduherminio merged commit 9c9b2fb into main Aug 3, 2024
27 checks passed
@eduherminio eduherminio deleted the cleanup/move-eval-to-separated-file-2-eval-terms branch August 3, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant