Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker support for x86/ARM #37

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Added Docker support for x86/ARM #37

merged 4 commits into from
Aug 8, 2024

Conversation

tenekev
Copy link
Contributor

@tenekev tenekev commented Apr 16, 2024

Love the project! I was surprised to see the lack of Docker support.

  • Added a Docker workflow. Upon a push, the workflow creates images for x86/ARM and publishes them on ghcr.io. This simplifies the deployment process, compared to Docker Hub. ⚠️You might need to update the repo settings to allow users to see and download images.
  • Added a docker-compose.yml that can be used to pull and deploy the aforementioned image.
  • Updated the readme to reflect the changes in a section called "Self-hosting with Docker 🐋".

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mini-qr-code-generator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2024 9:27pm

@lyqht
Copy link
Owner

lyqht commented Aug 8, 2024

thanks, looks good, i will merge this!

@Alcann
Copy link

Alcann commented Aug 8, 2024

It's possible to add a docker-compose.yml for ARM ?
Because this docker is exclusive for amd64, thanks you :)

@lyqht
Copy link
Owner

lyqht commented Aug 8, 2024

could you add a PR for that? I've no idea what the diffs are.

@lyqht
Copy link
Owner

lyqht commented Aug 8, 2024

if possible, change the docker-compose yml so users can input their own machine type

@Alcann
Copy link

Alcann commented Aug 8, 2024

Sorry but i don't know do that, i'm not an expert in docker.
But it's possible that an other personn do this ?
I can wait ^^'

@Alcann
Copy link

Alcann commented Aug 8, 2024

I'm this error : no matching manifest for linux/arm/v8 in the manifest list entries
Do you know manifests ?

@lyqht
Copy link
Owner

lyqht commented Aug 8, 2024

@Alcann can you create another issue to request for this? i'm also not familiar with docker stuff. I can't reopen the issue, so people might not see your request to help out with it.

@lyqht lyqht changed the title Added Docker support Added Docker support for x86/ARM Aug 8, 2024
@Alcann
Copy link

Alcann commented Aug 10, 2024

Ok @lyqht sorry, it's ok ! I open a new issue for this problem, thank you for all ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants