上移Toast位置避免遮挡播放模式图标 #603
Merged
上移Toast位置避免遮挡播放模式图标 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢提供 PR， |
|
@lyswhut 感谢处理PR，之前应用中不记得有其他位置的toast，所以没有改动和测试。另外我试了一下现在的80像素，在我这里还是挡住的，比较尴尬，所以要不还是改大点？ |
|
改成100呢？你看看最小多少合适 |
|
我这里改到120刚好不挡。另外我这边android studio的默认模拟器上，也是需要这个偏移的，不知道是不是我们的测试环境不太一致。以下两图是120在真机和模拟器上的效果 |
|
那就用120，我回头改下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前默认Toast位置在底边，在播放界面点击播放模式的时候，toast正好把播放模式图标遮挡住。因为大多数场景下，用户希望连续点击图标，切换到自己想要的模式，但是toast更新要1秒钟，导致很难知道现在实际的播放模式是啥，而是要等到多条toast都消失才能看到。所以希望挪一下位置，这样直接看图标就知道当前的模式。