Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node Name to Consumer #80

Open
2 tasks
schmichael opened this issue Dec 22, 2014 · 0 comments
Open
2 tasks

Add Node Name to Consumer #80

schmichael opened this issue Dec 22, 2014 · 0 comments
Labels
enhancement help wanted RFC

Comments

@schmichael
Copy link
Contributor

@epsniff brought up a good point:

Could the Consumer have a Node() method?

via https://github.com/lytics/metafora/pull/79/files#r22186794

Right now the node name is an etcd-Coordinator specific concept. None of the core interfaces or Consumer have any name support.

Enforcing a cluster-unique name for each node/consumer seems like a generally good idea.

Possible Solution

  • Add either a node string parameter to metafora.Consumer - or switch to passing in a (new) ConsumerConfig struct which would contain the node name.
    • The consumer should default the node name to <hostname>-<uuid>
  • Add a Node() string method to CoordinatorContext and BalancerContext for them to use as they see fit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schmichael