Export Consumer.Frozen and add http introspection handler #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Consumer contains just the Metafora methods exposed by the HTTP | ||
| // introspection endpoints. | ||
| type Consumer interface { |
There was a problem hiding this comment.
Why Consumer for a name? Im not sure that describes the interface's relationship to the metafora project. From the code it appears to be a metadata provider for the current metafora peer. Anyway, not a blocker.
There was a problem hiding this comment.
I think I understand the name now... Its a consumed by the http handler.
There was a problem hiding this comment.
Eh, I wasn't even that clever... I just stole the name from metafora.go where it's implemented. I'll give it a few minutes of thought to try to come up with a better interface name before hitting the merge button. You know how I love making things idiomatic! :)
|
👍 |
|
📨📨📨 |
schmichael
added a commit
that referenced
this pull request
Dec 22, 2014
Export Consumer.Frozen and add http introspection handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http handler is copied from our internal metafora runner.