Switch task ID to Task interface throughout. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core Consumer now has a RunningTask interface that wraps the underlying Task interface so that the struct underlying the Task interface returned by a Coordinator remains unchanged. This allows users to implement coordinator-specific Task structs, although Balancers and Handlers will have to type assert/switch the metafora.Task to the cooordinator-specific implementation. To allow for coordinator reuse with Task implementation variation, th m_etcd.Coordinator allows users to define a custom NewTask function to unmarshal the etcd task node into a use case specific struct.
|
nice! 👍 much more flexible interface |
|
👍 |
schmichael
added a commit
that referenced
this pull request
Jul 22, 2015
Switch task ID to Task interface throughout.
This was referenced Aug 5, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to implement coordinator-specific Task structs,
although Balancers and Handlers will have to type assert/switch the
metafora.Task to the cooordinator-specific implementation.
To allow for coordinator reuse with Task implementation variation, the
m_etcd.Coordinator allows users to define a custom NewTask function to
unmarshal the etcd task node into a use case specific struct.
Core Consumer now has a RunningTask interface that wraps the underlying
Task interface so that the struct underlying the Task interface returned
by a Coordinator remains unchanged.