Add CLEVA Schema #43
Add CLEVA Schema #43
Conversation
| when: "?" | ||
| what: e-commercial | ||
| who: customers and representatives | ||
| when: n/a |
There was a problem hiding this comment.
Maybe an unknown "?" is more appropriate?
There was a problem hiding this comment.
I think "?" stands for unknown and "n/a" means this field is not necessary. In most cases, I believe we just don't know "who" wrote "what" at "when", but it does not mean that these fields are not needed. Correct me if I am wrong.
There was a problem hiding this comment.
I understand your point of view, and I will gladly accept it if you insist. In my opinion, I feel like "?" means this field is missing and will be filled later after some examinations, while "n/a" means the creation time of the data does not matter too much, and the data is not time-sensitive.
I can do either way. Please let me know what you think. Thanks.
There was a problem hiding this comment.
I can also change the value to something like "not specified" to deliver a more clear indication.
There was a problem hiding this comment.
Perhaps we can stay this way and let the HELM team decide.
There was a problem hiding this comment.
They should have some guidelines on how to fill out this schema.yaml in the future.
|
I push my code to reflect all the discussions above. Have a look. Thanks! |
There was a problem hiding this comment.
I have no other comments. Good job! I think this PR is ready to be merged and @Jianqiao-Zhao could review other parts. Thanks.
This PR adds CLEVA schema to
schema.yamlaccording to the scaffolding of this HELM PR.