Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LZ4{Block|Frame}InputStream.skip in some corner cases #120

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Fix LZ4{Block|Frame}InputStream.skip in some corner cases #120

merged 1 commit into from
Jan 4, 2018

Conversation

windie
Copy link
Contributor

@windie windie commented Jan 4, 2018

According to InputStream.skip javadoc, LZ4{Block|Frame}InputStream.skip should return 0 when n <= 0 or EOF.

@windie
Fix LZ4{Block|Frame}InputStream.skip in some corner cases
1db54df 
According to `InputStream.skip` javadoc, `LZ4{Block|Frame}InputStream.skip` should return 0 when `n <= 0` or EOF.
@odaira odaira merged commit f78c4d9 into lz4:master Jan 4, 2018
@odaira
Copy link
Member

odaira commented Jan 4, 2018

Yes..., I think you are correct. Thanks for the fix!

@windie windie deleted the fix-skip branch January 5, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@windie @odaira