Skip to content

Commit

Permalink
[3.12] gh-113171: gh-65056: Fix "private" (non-global) IP address ran…
Browse files Browse the repository at this point in the history
…ges (GH-113179) (GH-113186) (GH-118177)

* GH-113171: Fix "private" (non-global) IP address ranges (GH-113179)

The _private_networks variables, used by various is_private
implementations, were missing some ranges and at the same time had
overly strict ranges (where there are more specific ranges considered
globally reachable by the IANA registries).

This patch updates the ranges with what was missing or otherwise
incorrect.

100.64.0.0/10 is left alone, for now, as it's been made special in [1].

The _address_exclude_many() call returns 8 networks for IPv4, 121
networks for IPv6.

[1] python/cpython#61602

* GH-65056: Improve the IP address' is_global/is_private documentation (GH-113186)

It wasn't clear what the semantics of is_global/is_private are and, when
one gets to the bottom of it, it's not quite so simple (hence the
exceptions listed).

(cherry picked from commit 2a4cbf17af19a01d942f9579342f77c39fbd23c4)
(cherry picked from commit 40d75c2b7f5c67e254d0a025e0f2e2c7ada7f69f)

---------

Co-authored-by: Jakub Stasiak <jakub@stasiak.at>

CPython-sync-commit-latest: f86b17ac511e68192ba71f27e752321a3252cee3
  • Loading branch information
github-actions[bot] committed Apr 24, 2024
1 parent 7d47d9d commit 27d6830
Show file tree
Hide file tree
Showing 3 changed files with 12,982 additions and 12,905 deletions.
Loading

0 comments on commit 27d6830

Please sign in to comment.