Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16 feature/create web UI #31

Merged
merged 10 commits into from
Sep 3, 2024
Merged

16 feature/create web UI #31

merged 10 commits into from
Sep 3, 2024

Conversation

EhabY
Copy link
Collaborator

@EhabY EhabY commented Aug 21, 2024

Created a simple UI using React and Chakra UI

The app currently has the following features:

  • Stack statuses are fetched from "/stacks"
  • A search bar that filters based on all the status properties
  • Support for light and dark theme
  • A link to this GitHub Repo

I have also made sure to configure eslint and prettier to achieve the best results for an error free and nice looking code. Please use VS Code with the following options (.vscode/settings.json):

{
  "editor.codeActionsOnSave": {
    "source.organizeImports": "always",
    "source.fixAll.eslint": "always"
  },
  "editor.formatOnSave": true,
  "eslint.format.enable": true,
  "eslint.lintTask.enable": true,
  "editor.tabSize": 2
}

@EhabY EhabY self-assigned this Aug 21, 2024
m-adawi
m-adawi previously approved these changes Aug 25, 2024
Copy link
Owner

@m-adawi m-adawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EhabY! The UI looks so neat

EhabY and others added 7 commits August 25, 2024 23:52
* Added eslint and prettier configurations
* Added header with search bar, github link, and theme switch button
Co-authored-by: Ehab Younes <ehab.alyounes@gmail.com>
* Add recommended extensions
* Better filtering
* Added message when there is nothing to show
@m-adawi m-adawi self-requested a review August 25, 2024 20:56
m-adawi
m-adawi previously approved these changes Aug 25, 2024
@sanzoghenzo
Copy link
Collaborator

Hi!
I still have to try it, will do ASAP!

In the meantime, I only want to suggest the use of biome instead of prettier and eslint, it's way faster 😉

@yazan-abu-obaideh
Copy link
Collaborator

Has Dependabot been configured to upgrade the npm dependencies?

@sanzoghenzo
Copy link
Collaborator

sanzoghenzo commented Aug 27, 2024

I'm a total newbie in golang, so maybe I'm missing something, but I got 404 errors until I changed the paths in the router to be like ../ui/dist instead of ui/dist. Is this because I'm using go run main.go inside the cmd folder?

EDIT: nevermind, I had to run it from the root folder 😅

@EhabY
Copy link
Collaborator Author

EhabY commented Aug 28, 2024

Hi! I still have to try it, will do ASAP!

In the meantime, I only want to suggest the use of biome instead of prettier and eslint, it's way faster 😉

I'll land this with Eslint & Prettier but I'll take a look at Biome if it makes sense :)!

@EhabY EhabY merged commit a5dc955 into main Sep 3, 2024
1 check passed
@sanzoghenzo sanzoghenzo deleted the 16-feature/create-web-ui branch September 25, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants