Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "more recent" versions of macos to test matrix #3

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

connorferster
Copy link
Collaborator

  • macos-latest is apparently macos 12. 13 and 14 need to be specified exactly. 14 is on M1.

@robbievanleeuwen
Copy link

robbievanleeuwen commented Jun 11, 2024

@connorferster, I ran into this recently. GitHub actions now uses the following:

  • macos-latest is macos-14 and uses an M1 processor (arm64)
  • macos-13 uses an intel processor (x86-64)

Info can be found here.

My CI started failing and I finally realised that the mac image got updated from an intel to arm processor and hence triangle could not be installed. I'm therefore currently only running CI on macos-13. If cytriangle could build both macos-13 and macos-latest I believe this would cover all bases!

@m-clare
Copy link
Owner

m-clare commented Jun 11, 2024

LGTM. I'd built successfully against section-properties locally but was still trying to figure out why it failed CI. Thanks!

@m-clare m-clare merged commit 8bfa0d1 into main Jun 11, 2024
20 checks passed
@robbievanleeuwen
Copy link

Just a heads up that the macos-14 and macos-latest workflows are identical so you probably only need one of these :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants