Collects broadcast packet metrics #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original DISCOv1 used to collect both broadcast and multicast metrics, but for some reason I chose not to collect those for DISCOv2. Upon closer inspection, we decided that while multicast packet metrics were indeed not necessary, that broadcast packet metrics could possible be useful. This commit adds collection for ingress and egress broadcast packets.
robertodauria
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original DISCOv1 used to collect both broadcast and multicast
metrics, but for some reason I chose not to collect those for DISCOv2.
Upon closer inspection, we decided that while multicast packet metrics
were indeed not necessary, that broadcast packet metrics could possibly
be useful. This commit adds collection for ingress and egress broadcast
packets.
This change is