Skip to content

Commit

Permalink
a possible fix for TAINTED_SCALAR coverity issues
Browse files Browse the repository at this point in the history
Signed-off-by: Mahdi Varasteh <varasteh@amnesh.ir>
  • Loading branch information
m-varasteh committed Sep 20, 2023
1 parent 7a80a23 commit e78e7b7
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions ospfd/ospf_auth.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ static int ospf_auth_check_md5_digest(struct ospf_interface *oi,
unsigned char digest[OSPF_AUTH_MD5_SIZE];
struct ospf_neighbor *nbr;
struct crypt_key *ck = NULL;
uint16_t length = ntohs(ospfh->length);
unsigned int length = ntohs(ospfh->length);

if (key == NULL) {
ck = ospf_crypt_key_lookup(OSPF_IF_PARAM(oi, auth_crypt),
Expand Down Expand Up @@ -225,7 +225,7 @@ static int ospf_auth_make_md5_digest(struct ospf_interface *oi,
void *ibuf;
struct ospf_header *ospfh;
unsigned char digest[OSPF_AUTH_MD5_SIZE];
uint16_t length;
unsigned int length = ntohs(ospfh->length);
#ifdef CRYPTO_OPENSSL
EVP_MD_CTX *ctx;
#elif CRYPTO_INTERNAL
Expand All @@ -237,7 +237,6 @@ static int ospf_auth_make_md5_digest(struct ospf_interface *oi,
strlcpy(auth_key, key->string, OSPF_AUTH_MD5_SIZE + 1);
ibuf = STREAM_DATA(op->s);
ospfh = (struct ospf_header *)ibuf;
length = ntohs(ospfh->length);
/* Generate a digest for the ospf packet - their digest + our digest. */
#ifdef CRYPTO_OPENSSL
unsigned int md5_size = OSPF_AUTH_MD5_SIZE;
Expand Down

0 comments on commit e78e7b7

Please sign in to comment.