Skip to content

update deps 1

update deps 1 #38

GitHub Actions / clippy failed Jul 23, 2024 in 0s

clippy

11 errors, 22 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 11
Warning 22
Note 0
Help 0

Versions

  • rustc 1.82.0-nightly (cefe1dcef 2024-07-22)
  • cargo 1.82.0-nightly (5f6b9a922 2024-07-19)
  • clippy 0.1.81 (cefe1dc 2024-07-22)

Annotations

Check warning on line 621 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> src/main.rs:621:7
    |
621 |                 ..Default::default()
    |                   ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
    = note: `#[warn(clippy::needless_update)]` on by default

Check warning on line 121 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map` over `inspect`

warning: using `map` over `inspect`
   --> src/main.rs:121:5
    |
121 |             .map(|val| {
    |              ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
    = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
    |
121 ~             .inspect(|val| {
122 ~                 val.calc_mod_map();
    |

Check failure on line 215 in src/widget/dots.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `usize` to `u16` may truncate the value

error: casting `usize` to `u16` may truncate the value
   --> src/widget/dots.rs:215:38
    |
215 | ...                   shell.publish((self.on_click)(i as u16));
    |                                                     ^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
    = note: `#[deny(clippy::cast_possible_truncation)]` implied by `#[deny(clippy::pedantic)]`
help: ... or use `try_from` and handle the error accordingly
    |
215 |                             shell.publish((self.on_click)(u16::try_from(i)));
    |                                                           ~~~~~~~~~~~~~~~~

Check failure on line 254 in src/view/splat_extras.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant redefinition of a binding `wolf_gifts`

error: redundant redefinition of a binding `wolf_gifts`
   --> src/view/splat_extras.rs:254:6
    |
254 |                     let wolf_gifts = wolf_gifts;
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
help: `wolf_gifts` is initially defined here
   --> src/view/splat_extras.rs:225:8
    |
225 |             let wolf_gifts: Vec<Translated<WolfGift>> = WolfGift::all()
    |                 ^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals

Check failure on line 237 in src/view/splat_extras.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant redefinition of a binding `shadow_gifts`

error: redundant redefinition of a binding `shadow_gifts`
   --> src/view/splat_extras.rs:237:6
    |
237 |                     let shadow_gifts = shadow_gifts;
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
help: `shadow_gifts` is initially defined here
   --> src/view/splat_extras.rs:220:8
    |
220 |             let shadow_gifts: Vec<Translated<ShadowGift>> = ShadowGift::all()
    |                 ^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals

Check failure on line 260 in src/view/overview.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `u16` to `i16` may wrap around the value

error: casting `u16` to `i16` may wrap around the value
   --> src/view/overview.rs:260:29
    |
260 |                     character.base_size = (val as i16 - character.get_modifier(Trait::Size)) as u16;
    |                                            ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
    = note: `#[deny(clippy::cast_possible_wrap)]` implied by `#[deny(clippy::pedantic)]`

Check failure on line 260 in src/view/overview.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `i16` to `u16` may lose the sign of the value

error: casting `i16` to `u16` may lose the sign of the value
   --> src/view/overview.rs:260:28
    |
260 |                     character.base_size = (val as i16 - character.get_modifier(Trait::Size)) as u16;
    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
    = note: `#[deny(clippy::cast_sign_loss)]` implied by `#[deny(clippy::pedantic)]`

Check warning on line 26 in src/view/creator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> src/view/creator.rs:23:1
   |
23 | / pub enum Event {
24 | |     SplatChanged(Splat),
   | |     ------------------- the largest variant contains at least 208 bytes
25 | |     Done,
   | |     ---- the second-largest variant carries no data at all
26 | | }
   | |_^ the entire enum is at least 208 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
24 |     SplatChanged(Box<Splat>),
   |                  ~~~~~~~~~~

Check warning on line 86 in src/i18n.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
  --> src/i18n.rs:86:42
   |
86 |     let localizer_arc: Arc<dyn Localizer> = Arc::new(localizer);
   |                                             ^^^^^^^^^^^^^^^^^^^
   |
   = note: `Arc<DefaultLocalizer<'_>>` is not `Send` and `Sync` as `DefaultLocalizer<'_>` is neither `Send` nor `Sync`
   = help: if the `Arc` will not used be across threads replace it with an `Rc`
   = help: otherwise make `DefaultLocalizer<'_>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
   = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check failure on line 109 in src/component/traits.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary boolean `not` operation

error: unnecessary boolean `not` operation
   --> src/component/traits.rs:101:22
    |
101 |           let alternate_xp = if !self.traits.alt_opt {
    |  ____________________________^
102 | |             row![text(format!(
103 | |                 "{}: {}",
104 | |                 flt(&self.traits.splat, Some("experience")).unwrap(),
...   |
108 | |             row![]
109 | |         };
    | |_________^
    |
    = help: remove the `!` and swap the blocks of the `if`/`else`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else

Check failure on line 99 in src/component/traits.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary boolean `not` operation

error: unnecessary boolean `not` operation
  --> src/component/traits.rs:86:25
   |
86 |           let alternate_beats = if !self.traits.alt_opt {
   |  _______________________________^
87 | |             row![
88 | |                 text(format!(
89 | |                     "{}:",
...  |
98 | |             row![]
99 | |         };
   | |_________^
   |
   = help: remove the `!` and swap the blocks of the `if`/`else`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else

Check failure on line 116 in src/component/skills.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary boolean `not` operation

error: unnecessary boolean `not` operation
   --> src/component/skills.rs:112:6
    |
112 | /                     if !specialties.is_empty() {
113 | |                         theme::Text::Color(Color::from_rgb(0.0, 0.7, 0.0))
114 | |                     } else {
115 | |                         theme::Text::Default
116 | |                     },
    | |_____________________^
    |
    = help: remove the `!` and swap the blocks of the `if`/`else`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else
    = note: `#[deny(clippy::if_not_else)]` implied by `#[deny(clippy::pedantic)]`

Check failure on line 94 in src/component/skills.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant redefinition of a binding `skill`

error: redundant redefinition of a binding `skill`
  --> src/component/skills.rs:94:7
   |
94 |                         let skill = skill;
   |                         ^^^^^^^^^^^^^^^^^^
   |
help: `skill` is initially defined here
  --> src/component/skills.rs:84:7
   |
84 |         for skill in Skill::get(cat) {
   |             ^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
   = note: `#[deny(clippy::redundant_locals)]` on by default

Check warning on line 47 in src/component/skills.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

all variants have the same postfix: `Changed`

warning: all variants have the same postfix: `Changed`
  --> src/component/skills.rs:42:1
   |
42 | / pub enum Event {
43 | |     SkillChanged(u16, Skill),
44 | |     RoteSkillChanged(Skill),
45 | |     SpecialtyChanged(Skill, usize, String),
46 | |     SpecialtySkillChanged(Skill),
47 | | }
   | |_^
   |
   = help: remove the postfixes and use full paths to the variants instead of glob imports
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
   = note: `#[warn(clippy::enum_variant_names)]` on by default

Check failure on line 207 in src/component/integrity.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many lines (120/100)

error: this function has too many lines (120/100)
   --> src/component/integrity.rs:74:2
    |
74  | /     fn view(&self, _state: &Self::State) -> Element<Self::Event> {
75  | |         let character = self.character.borrow();
76  | |
77  | |         let mut col = Column::new()
...   |
206 | |         col.into()
207 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
    = note: `#[deny(clippy::too_many_lines)]` implied by `#[deny(clippy::pedantic)]`

Check warning on line 61 in src/component/integrity.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
  --> src/component/integrity.rs:53:37
   |
53 |               Event::IntegrityDamage(wound) => match &mut character.splat {
   |  ______________________________________________^
54 | |                 Splat::Changeling(.., data) => {
55 | |                     data.clarity.poke(&wound);
56 | |                     if let Wound::Lethal = wound {
...  |
60 | |                 _ => {}
61 | |             },
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
   = note: `#[warn(clippy::single_match)]` on by default
help: try
   |
53 ~             Event::IntegrityDamage(wound) => if let Splat::Changeling(.., data) = &mut character.splat {
54 ~                        data.clarity.poke(&wound);
55 ~                        if let Wound::Lethal = wound {
56 ~                            data.clarity.poke(&Wound::Aggravated);
57 ~                        }
58 ~                    },
   |

Check warning on line 36 in src/view/equipment.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `abilities` is never used

warning: method `abilities` is never used
  --> src/view/equipment.rs:36:5
   |
28 | impl<Message> EquipmentTab<Message> {
   | ----------------------------------- method in this implementation
...
36 |     fn abilities(&self, _character: &Character) -> Element<Event> {
   |        ^^^^^^^^^

Check warning on line 86 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variant `Msg` is never constructed

warning: variant `Msg` is never constructed
  --> src/main.rs:86:2
   |
80 | enum Message {
   |      ------- variant in this enum
...
86 |     Msg,
   |     ^^^
   |
   = note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 1 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the feature `is_some_and` has been stable since 1.70.0 and no longer requires an attribute to enable

warning: the feature `is_some_and` has been stable since 1.70.0 and no longer requires an attribute to enable
 --> src/main.rs:1:12
  |
1 | #![feature(is_some_and)]
  |            ^^^^^^^^^^^
  |
  = note: `#[warn(stable_features)]` on by default

Check warning on line 11 in src/view/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `SplatExtrasTab`

warning: unused import: `SplatExtrasTab`
  --> src/view/mod.rs:11:42
   |
11 | pub use splat_extras::{splat_extras_tab, SplatExtrasTab};
   |                                          ^^^^^^^^^^^^^^

Check warning on line 10 in src/view/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `OverviewTab`

warning: unused import: `OverviewTab`
  --> src/view/mod.rs:10:34
   |
10 | pub use overview::{overview_tab, OverviewTab};
   |                                  ^^^^^^^^^^^

Check warning on line 9 in src/view/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `EquipmentTab`

warning: unused import: `EquipmentTab`
 --> src/view/mod.rs:9:36
  |
9 | pub use equipment::{equipment_tab, EquipmentTab};
  |                                    ^^^^^^^^^^^^

Check warning on line 8 in src/view/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `CreatorView`

warning: unused import: `CreatorView`
 --> src/view/mod.rs:8:33
  |
8 | pub use creator::{creator_view, CreatorView};
  |                                 ^^^^^^^^^^^

Check warning on line 7 in src/view/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `CharacterList`

warning: unused import: `CharacterList`
 --> src/view/mod.rs:7:42
  |
7 | pub use character_list::{character_list, CharacterList};
  |                                          ^^^^^^^^^^^^^

Check failure on line 295 in src/view/splat_extras.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

binding's name is too similar to existing binding

error: binding's name is too similar to existing binding
   --> src/view/splat_extras.rs:295:7
    |
295 |         let rites = if let Splat::Werewolf(.., data) = &character.splat {
    |             ^^^^^
    |
note: existing binding defined here
   --> src/view/splat_extras.rs:135:7
    |
135 |         let rotes: Element<Self::Event> = if let Splat::Mage(.., data) = &character.splat {
    |             ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names
note: the lint level is defined here
   --> src/main.rs:3:9
    |
3   | #![deny(clippy::pedantic)]
    |         ^^^^^^^^^^^^^^^^
    = note: `#[deny(clippy::similar_names)]` implied by `#[deny(clippy::pedantic)]`