Skip to content

Integration with latest cofd lib changes #45

Integration with latest cofd lib changes

Integration with latest cofd lib changes #45

GitHub Actions / clippy failed Jul 30, 2024 in 0s

clippy

5 errors, 25 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 5
Warning 25
Note 0
Help 0

Versions

  • rustc 1.82.0-nightly (2cbbe8b8b 2024-07-28)
  • cargo 1.82.0-nightly (b5d44db1d 2024-07-26)
  • clippy 0.1.82 (2cbbe8b 2024-07-28)

Annotations

Check warning on line 632 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> src/main.rs:632:7
    |
632 |                 ..Default::default()
    |                   ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
    = note: `#[warn(clippy::needless_update)]` on by default

Check failure on line 237 in src/widget/dots.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `usize` to `u16` may truncate the value

error: casting `usize` to `u16` may truncate the value
   --> src/widget/dots.rs:237:38
    |
237 | ...                   shell.publish((self.on_click)(i as u16));
    |                                                     ^^^^^^^^
    |
    = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation
    = note: `#[deny(clippy::cast_possible_truncation)]` implied by `#[deny(clippy::pedantic)]`
help: ... or use `try_from` and handle the error accordingly
    |
237 |                             shell.publish((self.on_click)(u16::try_from(i)));
    |                                                           ~~~~~~~~~~~~~~~~

Check warning on line 172 in src/view/splat_extras.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `Arcanum` which implements the `Copy` trait

warning: using `clone` on type `Arcanum` which implements the `Copy` trait
   --> src/view/splat_extras.rs:172:35
    |
172 |                         Some::<Translated<Arcanum>>(rote.arcanum.clone().into()),
    |                                                     ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rote.arcanum`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 504 in src/view/overview.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> src/view/overview.rs:500:37
    |
500 |               let (passive, common, specific): (
    |  ______________________________________________^
501 | |                 Element<Self::Event, Theme>,
502 | |                 Element<Self::Event, Theme>,
503 | |                 Element<Self::Event, Theme>,
504 | |             ) = if let KuruthTriggers::_Custom(KuruthTriggerSet {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default

Check failure on line 277 in src/view/overview.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `u16` to `i16` may wrap around the value

error: casting `u16` to `i16` may wrap around the value
   --> src/view/overview.rs:277:29
    |
277 |                     character.base_size = (val as i16
    |                                            ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap
    = note: `#[deny(clippy::cast_possible_wrap)]` implied by `#[deny(clippy::pedantic)]`

Check failure on line 279 in src/view/overview.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `i16` to `u16` may lose the sign of the value

error: casting `i16` to `u16` may lose the sign of the value
   --> src/view/overview.rs:277:28
    |
277 |                       character.base_size = (val as i16
    |  ___________________________________________^
278 | |                         - character.get_modifier(Trait::DerivedTrait(DerivedTrait::Size)))
279 | |                         as u16;
    | |______________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
    = note: `#[deny(clippy::cast_sign_loss)]` implied by `#[deny(clippy::pedantic)]`

Check warning on line 27 in src/view/creator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> src/view/creator.rs:24:1
   |
24 | / pub enum Event {
25 | |     SplatChanged(Splat), // TODO: Switch to using a unit-varianted "SplatKind" enum here
   | |     ------------------- the largest variant contains at least 424 bytes
26 | |     Done,
   | |     ---- the second-largest variant carries no data at all
27 | | }
   | |_^ the entire enum is at least 424 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
25 |     SplatChanged(Box<Splat>), // TODO: Switch to using a unit-varianted "SplatKind" enum here
   |                  ~~~~~~~~~~

Check warning on line 78 in src/i18n.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
  --> src/i18n.rs:78:3
   |
78 |         Arc::new(DefaultLocalizer::new(&*LANGUAGE_LOADER, &Localizations));
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `Arc<DefaultLocalizer<'_>>` is not `Send` and `Sync` as `DefaultLocalizer<'_>` is neither `Send` nor `Sync`
   = help: if the `Arc` will not used be across threads replace it with an `Rc`
   = help: otherwise make `DefaultLocalizer<'_>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
   = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 100 in src/component/traits.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `if` has identical blocks

warning: this `if` has identical blocks
   --> src/component/traits.rs:98:45
    |
98  |           let alternate_xp = if self.traits.alt_opt {
    |  ___________________________________________________^
99  | |             row![]
100 | |         } else {
    | |_________^
    |
note: same as this
   --> src/component/traits.rs:100:10
    |
100 |           } else {
    |  ________________^
101 | |             row![
102 | |             //     text(format!(
103 | |             //     "{}: {}",
...   |
107 | |             ]
108 | |         };
    | |_________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
    = note: `#[warn(clippy::if_same_then_else)]` on by default

Check failure on line 67 in src/component/info.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variables can be used directly in the `format!` string

error: variables can be used directly in the `format!` string
  --> src/component/info.rs:67:26
   |
67 |             col1 = col1.push(text(format!("{}:", str)));
   |                                   ^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
   = note: `#[deny(clippy::uninlined_format_args)]` implied by `#[deny(clippy::pedantic)]`
help: change this to
   |
67 -             col1 = col1.push(text(format!("{}:", str)));
67 +             col1 = col1.push(text(format!("{str}:")));
   |

Check warning on line 16 in src/component/traits.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `alternate_beats`, `alternate_experience`, and `splat` are never read

warning: fields `alternate_beats`, `alternate_experience`, and `splat` are never read
  --> src/component/traits.rs:16:2
   |
9  | struct Traits {
   |        ------ fields in this struct
...
16 |     alternate_beats: u16,
   |     ^^^^^^^^^^^^^^^
17 |     alternate_experience: u16,
   |     ^^^^^^^^^^^^^^^^^^^^
...
21 |     splat: String,
   |     ^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 70 in src/widget/track.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `renderer`

warning: unused variable: `renderer`
  --> src/widget/track.rs:70:3
   |
70 |         renderer: &Renderer,
   |         ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_renderer`

Check warning on line 69 in src/widget/track.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `tree`

warning: unused variable: `tree`
  --> src/widget/track.rs:69:3
   |
69 |         tree: &mut widget::Tree,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_tree`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 301 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Splat`

warning: unused import: `Splat`
   --> src/main.rs:301:77
    |
301 |         splat::{changeling::*, geist::*, mage::*, vampire::*, werewolf::*, Merit, Splat},
    |                                                                                   ^^^^^

Check warning on line 8 in src/widget/track.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Alignment`

warning: unused import: `Alignment`
 --> src/widget/track.rs:8:19
  |
8 | use iced::{mouse, Alignment, Border, Color, Element, Length, Rectangle, Size};
  |                   ^^^^^^^^^

Check warning on line 6 in src/widget/track.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Column` and `Row`

warning: unused imports: `Column` and `Row`
 --> src/widget/track.rs:6:26
  |
6 | use iced::widget::{text, Column, Row};
  |                          ^^^^^^  ^^^

Check warning on line 9 in src/widget/dots.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Alignment`

warning: unused import: `Alignment`
 --> src/widget/dots.rs:9:19
  |
9 | use iced::{mouse, Alignment, Border, Color, Element, Length, Rectangle, Size};
  |                   ^^^^^^^^^

Check warning on line 8 in src/widget/dots.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Padding`

warning: unused import: `Padding`
 --> src/widget/dots.rs:8:38
  |
8 | use iced::{event, touch, Background, Padding, Point, Theme};
  |                                      ^^^^^^^

Check warning on line 7 in src/widget/dots.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Column` and `Row`

warning: unused imports: `Column` and `Row`
 --> src/widget/dots.rs:7:26
  |
7 | use iced::widget::{text, Column, Row};
  |                          ^^^^^^  ^^^

Check warning on line 1 in src/widget/dots.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `std::array`

warning: unused import: `std::array`
 --> src/widget/dots.rs:1:5
  |
1 | use std::array;
  |     ^^^^^^^^^^

Check failure on line 297 in src/view/splat_extras.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

binding's name is too similar to existing binding

error: binding's name is too similar to existing binding
   --> src/view/splat_extras.rs:297:7
    |
297 |         let rites = if let Splat::Werewolf(.., data) = &character.splat {
    |             ^^^^^
    |
note: existing binding defined here
   --> src/view/splat_extras.rs:150:7
    |
150 |         let rotes: Element<Self::Event, Theme> = if let Splat::Mage(.., data) = &character.splat {
    |             ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#similar_names
note: the lint level is defined here
   --> src/main.rs:2:9
    |
2   | #![deny(clippy::pedantic)]
    |         ^^^^^^^^^^^^^^^^
    = note: `#[deny(clippy::similar_names)]` implied by `#[deny(clippy::pedantic)]`

Check warning on line 1 in src/view/equipment.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `marker::PhantomData`

warning: unused import: `marker::PhantomData`
 --> src/view/equipment.rs:1:26
  |
1 | use std::{cell::RefCell, marker::PhantomData, rc::Rc};
  |                          ^^^^^^^^^^^^^^^^^^^

Check warning on line 9 in src/view/creator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `i18n::Translate`

warning: unused import: `i18n::Translate`
 --> src/view/creator.rs:9:13
  |
9 | use crate::{i18n::Translate, INPUT_PADDING};
  |             ^^^^^^^^^^^^^^^

Check warning on line 21 in src/i18n.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `OnceCell`

warning: unused import: `OnceCell`
  --> src/i18n.rs:21:29
   |
21 | use once_cell::sync::{Lazy, OnceCell};
   |                             ^^^^^^^^

Check warning on line 7 in src/i18n.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `NameKey`

warning: unused import: `NameKey`
 --> src/i18n.rs:7:26
  |
7 | use cofd::splat::{Merit, NameKey, Splat, XSplat, YSplat, ZSplat};
  |                          ^^^^^^^