TRY-198: review fix

m10-payments · Dec 26, 2023 · b9f4567 · b9f4567
1 parent 5fc0da8
commit b9f4567
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/java/api/src/main/java/com/exadel/frs/core/trainservice/cache/EmbeddingCollection.java b/java/api/src/main/java/com/exadel/frs/core/trainservice/cache/EmbeddingCollection.java
@@ -49,10 +49,10 @@ public static EmbeddingCollection from(final Stream<EnhancedEmbeddingProjection>
     }
 
     // TODO: provide immutable wrapper for EmbeddingCollection here
-    public <T> T doWithReadLock(Function<EmbeddingCollection, T> readAndDo) {
+    public <T> T doWithReadLock(Function<Map<EmbeddingProjection, RealVector>, T> readAndDo) {
         readLock.lock();
         try {
-            return readAndDo.apply(this);
+            return readAndDo.apply(exposeMap());
         } finally {
             readLock.unlock();
         }
@@ -69,7 +69,8 @@ Collection<RealVector> getEmbeddings() {
         return Collections.unmodifiableCollection(mapping.values());
     }
 
-    public Map<EmbeddingProjection, RealVector> exposeMap() {
+    // package private for test purposes
+    Map<EmbeddingProjection, RealVector> exposeMap() {
         return Collections.unmodifiableMap(mapping);
     }
 

diff --git a/...a/com/exadel/frs/core/trainservice/component/classifiers/EuclideanDistanceClassifier.java b/...a/com/exadel/frs/core/trainservice/component/classifiers/EuclideanDistanceClassifier.java
@@ -55,7 +55,7 @@ public List<Pair<Double, String>> predict(final double[] input, final String api
         var coefficients = getSimilarityCoefficients();
         return embeddingCacheProvider.getOrLoad(apiKey)
                 .doWithReadLock(
-                        ec -> ec.exposeMap().entrySet()
+                        ec -> ec.entrySet()
                                 .stream()
                                 .map(e -> Pair.of(e.getKey(), e.getValue().getDistance(inputFace)))
                                 .map(p -> Pair.of(p.getKey(), calculateSimilarity(p.getValue(), coefficients)))