Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Neko variants to drop-down menu #2

Merged
merged 1 commit into from Apr 2, 2021
Merged

Add missing Neko variants to drop-down menu #2

merged 1 commit into from Apr 2, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2021

This pull request adds the other tags of the Neko image to the drop-down menu.

Signed-off-by: Aaron <admin@datahoarder.dev>
@m1k1o
Copy link
Owner

m1k1o commented Apr 2, 2021

Thanks!

With VLC it would be nice to have ability to mount custom media directroy. Also maybe storing browser profiles.

And maybe specifying own ENV variables could be beneficial:

  • VLC_MEDIA what specifies directory / initial media that should be played
  • NEKO_VNC_URL for vncviewer, to set remote URL to connect to.

I should add this to roadmap.

@m1k1o m1k1o merged commit 1d43e7f into m1k1o:master Apr 2, 2021
@ghost ghost deleted the patch-1 branch April 2, 2021 20:56
@ghost
Copy link
Author

ghost commented Apr 2, 2021

@m1k1o Yeah, that sounds good to me. It'd probably be best to allow user input for those options in the expert settings section.

Btw, can you enable automated builds for this repository on Docker Hub?

@m1k1o
Copy link
Owner

m1k1o commented Apr 2, 2021

Yes, but my only concern is about security with custom volumes. That could be potentially abused to mount any directory on host, so it needs to be good secured.

Auto-deploy is enabled, but docker-hub seems to be really slow today:
image

@ghost
Copy link
Author

ghost commented Apr 2, 2021

@m1k1o Good point, I hadn't considered that. Maybe users could be offered a list of directories to choose from like with the different tags. This list of directories could be controlled by the administrator using environment variables on the Neko Rooms container, e.g. NEKO_ROOMS_DIRECTORY_WHITELIST.

@m1k1o
Copy link
Owner

m1k1o commented Apr 2, 2021

Yeah, that would go. Having pool of directories that can be used.

But if we want to save user profiles of multiple instances, then there would need to be created subdirectories. And then allowing only some regex for folder names e.g. A-Za-z0-9-_. so that no path traversal could take place. That would probably need additional logic -> data manager, where user could manage data. It must be also ensured, that one data folder is mounted maximum to 1 container at a time.

Seems to be more complex, I am generally open for ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant