-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow persistent data for container #9
Conversation
Should mount
They need to match, otherwise it won't work. |
Neko rooms is running as root (even if only inside container), although it does not need to. And creatilg file results again to a file owned by root. |
There should be posibility to add readonly template files from a shared directory, rather that having everything split per rooms. And additionaly allow whitelisted external mounts (for downloads folder, or media...). |
Maybe neko-rooms could copy its data mountpoint information (since it has access to docker socket) and use that, instead of setting another external env variable. Update: Needs refactoring, new PR. |
This PR is adding functionality to mount folders to containers. User's path root will be changed to custom container folder in instance data folder:
<instance.data>/<container.name>/<users.path>
.To do
root:root
user, and is not accessible forneko
user inside container./../
to path. (fixed in 1345118)