Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix dumped file names in troubleshooting guide #2727

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Oct 13, 2020

What this PR does / why we need it:
The docs did not contain valid names of dumped files.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@linasm linasm added the area:documentation All issues pertaining to usability and documentation label Oct 13, 2020
@linasm linasm force-pushed the linasm/fix-file-names-in-troubleshooting-guide branch from a376425 to 046ab5d Compare October 21, 2020 08:57
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #2727 into master will increase coverage by 6.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2727     +/-   ##
========================================
+ Coverage    53.9%   60.8%   +6.9%     
========================================
  Files        1003    1015     +12     
  Lines       91413   92930   +1517     
========================================
+ Hits        49292   56568   +7276     
+ Misses      38002   31922   -6080     
- Partials     4119    4440    +321     
Flag Coverage Δ
#aggregator 64.3% <ø> (+8.4%) ⬆️
#cluster 77.6% <ø> (+33.7%) ⬆️
#collector 64.3% <ø> (+10.0%) ⬆️
#dbnode 63.6% <ø> (+2.2%) ⬆️
#m3em 52.6% <ø> (+1.4%) ⬆️
#m3ninx 60.9% <ø> (+2.8%) ⬆️
#m3nsch 51.1% <ø> (+22.7%) ⬆️
#msg 73.2% <ø> (-0.2%) ⬇️
#query 48.8% <ø> (+10.6%) ⬆️
#x 63.0% <ø> (+6.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e1aa2...a813d86. Read the comment docs.

@ChrisChinchilla
Copy link
Collaborator

@linasm I'll approave for now and likely test that these commands all work later when I rewrite the content fully.

@linasm linasm merged commit 50c2f97 into master Oct 23, 2020
@linasm linasm deleted the linasm/fix-file-names-in-troubleshooting-guide branch October 23, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation All issues pertaining to usability and documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants