Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce matching retention and index block size #2783

Merged
merged 16 commits into from
Oct 26, 2020

Conversation

rallen090
Copy link
Collaborator

@rallen090 rallen090 commented Oct 21, 2020

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, potential refactor suggestion

@arnikola arnikola removed their assignment Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #2783 into master will decrease coverage by 18.7%.
The diff coverage is 0.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2783      +/-   ##
=========================================
- Coverage    69.8%   51.1%   -18.8%     
=========================================
  Files        1111    1012      -99     
  Lines      100319   92560    -7759     
=========================================
- Hits        70115   47315   -22800     
- Misses      25258   41161   +15903     
+ Partials     4946    4084     -862     
Flag Coverage Δ
#aggregator 62.7% <ø> (-13.2%) ⬇️
#cluster 62.6% <ø> (-22.4%) ⬇️
#collector 64.3% <ø> (-20.0%) ⬇️
#dbnode 51.3% <ø> (-24.3%) ⬇️
#m3em 62.5% <ø> (-7.0%) ⬇️
#m3ninx 57.6% <ø> (-14.0%) ⬇️
#m3nsch 78.0% <ø> (+26.8%) ⬆️
#metrics ?
#msg 73.2% <ø> (-0.9%) ⬇️
#query 38.6% <0.0%> (-30.5%) ⬇️
#x 48.8% <ø> (-22.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c2f97...edbd7cd. Read the comment docs.

@rallen090 rallen090 merged commit 995d3bc into master Oct 26, 2020
@rallen090 rallen090 deleted the ra/prevent-inconsistent-block-sizes branch October 26, 2020 18:46
soundvibe added a commit that referenced this pull request Oct 29, 2020
* master:
  Support dynamic namespace resolution for embedded coordinators (#2815)
  [dbnode] Add index regexp DFA compilation cache to avoid allocating DFAs for same expressions (#2814)
  [dbnode] Set default cache on retrieve to false, prepare testing with cache none (#2813)
  [tools] Output annotations as base64 (#2743)
  Add Reset Transformation (#2794)
  [large-tiles] Fix for a reverse index when querying downsampled namespace (#2808)
  [dbnode] Evict info files cache before index bootstrap in peers bootstrapper (#2802)
  [dbnode] Bump default filesystem persist rate limit (#2806)
  [coordinator] Add metrics and configurability of downsample and ingest writer worker pool (#2797)
  [dbnode] Fix concurrency granularity of seekerManager.UpdateOpenLease (#2790)
  [dbnode] Use correct import path for atomic library (#2801)
  Regenerate carbon automapping rules on namespaces changes (#2793)
  Enforce matching retention and index block size (#2783)
  [query] Add ClusterNamespacesWatcher and use to generate downsample automapper rules (#2782)
  [query][dbnode] Wire up etcd-backed Clusters implementation in coordinator (#2758)
  [query] Fix quantile() argument not being passed through (#2780)

# Conflicts:
#	src/query/parser/promql/matchers.go
soundvibe added a commit that referenced this pull request Oct 29, 2020
* master:
  [query] Improve precision for variance and stddev of equal values (#2799)
  Support dynamic namespace resolution for embedded coordinators (#2815)
  [dbnode] Add index regexp DFA compilation cache to avoid allocating DFAs for same expressions (#2814)
  [dbnode] Set default cache on retrieve to false, prepare testing with cache none (#2813)
  [tools] Output annotations as base64 (#2743)
  Add Reset Transformation (#2794)
  [large-tiles] Fix for a reverse index when querying downsampled namespace (#2808)
  [dbnode] Evict info files cache before index bootstrap in peers bootstrapper (#2802)
  [dbnode] Bump default filesystem persist rate limit (#2806)
  [coordinator] Add metrics and configurability of downsample and ingest writer worker pool (#2797)
  [dbnode] Fix concurrency granularity of seekerManager.UpdateOpenLease (#2790)
  [dbnode] Use correct import path for atomic library (#2801)
  Regenerate carbon automapping rules on namespaces changes (#2793)
  Enforce matching retention and index block size (#2783)
  [query] Add ClusterNamespacesWatcher and use to generate downsample automapper rules (#2782)
  [query][dbnode] Wire up etcd-backed Clusters implementation in coordinator (#2758)
  [query] Fix quantile() argument not being passed through (#2780)
  [query] Add "median" aggregation to Graphite aggregate() function (#2774)
  [r2] Ensure KeepOriginal is propagated when adding/reviving rules (#2796)
  [dbnode] Update default db read limits  (#2784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants