Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update documentation for dynamic namespace configuration in Coordinator #2874

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

nbroyles
Copy link
Collaborator

What this PR does / why we need it:

This PR makes documentation reflect the preferred path for creating and configuring namespaces.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #2874 (603b00b) into master (b51a695) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2874   +/-   ##
======================================
  Coverage    71.9%   71.9%           
======================================
  Files        1096    1096           
  Lines       99772   99772           
======================================
+ Hits        71795   71815   +20     
+ Misses      23049   23036   -13     
+ Partials     4928    4921    -7     
Flag Coverage Δ
aggregator 75.8% <ø> (ø)
cluster 85.0% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 79.0% <ø> (+<0.1%) ⬆️
m3em 74.4% <ø> (ø)
m3ninx 73.1% <ø> (ø)
metrics 17.2% <ø> (ø)
msg 74.0% <ø> (-0.3%) ⬇️
query 68.8% <ø> (ø)
x 80.1% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51a695...603b00b. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbroyles nbroyles merged commit e130b7e into master Nov 12, 2020
@nbroyles nbroyles deleted the nb/update-documentation branch November 12, 2020 19:59
@ChrisChinchilla
Copy link
Collaborator

ChrisChinchilla commented Nov 13, 2020

@nbroyles I need a bit longer to review things! 😅 The whole section needs an update soon anyway, but would be good to wait for that review in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants