Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbnode] Update series metadata type name. #2946

Merged
merged 3 commits into from
Nov 24, 2020
Merged

[dbnode] Update series metadata type name. #2946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ccc4e3
Update type name.
notbdu Nov 24, 2020
731bf24
Update names.
notbdu Nov 24, 2020
6c38be3
Merge branch 'master' into bdu/persist-naming
notbdu Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dbnode/persist/fs/merger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func (m *merger) Merge(
Type: persist.SeriesDocumentType,
Document: seriesMetadata,
// The lifetime of the shard series metadata is longly lived.
LifeTime: persist.SeriesMetadataLifeTimeLong,
LifeTime: persist.SeriesLifeTimeLong,
},
})
}
Expand Down
8 changes: 4 additions & 4 deletions src/dbnode/persist/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,12 @@ const (
type SeriesMetadataLifeTime uint8

const (
// SeriesMetadataLifeTimeLong means the underlying memory's life time is long lived and exceeds
// SeriesLifeTimeLong means the underlying memory's life time is long lived and exceeds
// the execution duration of the series metadata receiver.
SeriesMetadataLifeTimeLong SeriesMetadataLifeTime = iota
// SeriesMetadataLifeTimeShortLived means that the underlying memory is only valid for the duration
SeriesLifeTimeLong SeriesMetadataLifeTime = iota
// SeriesLifeTimeShort means that the underlying memory is only valid for the duration
// of the OnFlushNewSeries call. Must clone the underlying bytes in order to extend the life time.
SeriesMetadataLifeTimeShortLived
SeriesLifeTimeShort
)

// SeriesMetadataType describes the type of series metadata.
Expand Down