Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbnode] Widen exposure of namespace method #2952

Merged
merged 2 commits into from
Nov 27, 2020
Merged

[dbnode] Widen exposure of namespace method #2952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a8f2c1
[dbnode] Widen exposure of namespace method
linasm Nov 27, 2020
1464497
Merge branch 'master' into linasm/expose-FetchWideEntry
linasm Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions src/dbnode/storage/storage_mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions src/dbnode/storage/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,14 @@ type Namespace interface {

// DocRef returns the doc if already present in a namespace shard.
DocRef(id ident.ID) (doc.Document, bool, error)

// FetchWideEntry retrieves wide entry for an ID for the
// block at time start.
FetchWideEntry(
ctx context.Context,
id ident.ID,
blockStart time.Time,
) (block.StreamedWideEntry, error)
}

// NamespacesByID is a sortable slice of namespaces by ID.
Expand Down Expand Up @@ -372,14 +380,6 @@ type databaseNamespace interface {
start, end time.Time,
) ([][]xio.BlockReader, error)

// FetchWideEntry retrieves the wide entry for an ID for the
// block at time start.
FetchWideEntry(
ctx context.Context,
id ident.ID,
blockStart time.Time,
) (block.StreamedWideEntry, error)

// FetchBlocks retrieves data blocks for a given id and a list of block
// start times.
FetchBlocks(
Expand Down