Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix Graphite asPercent function to handle nodes and multiple total divisor series #3142

Merged
merged 18 commits into from
Mar 18, 2021

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Jan 30, 2021

What this PR does / why we need it:

Fixes asPercent to handle nodes arg and multiple divisor series.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@wesleyk wesleyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #3142 (965f566) into master (8df132f) will increase coverage by 1.6%.
The diff coverage is n/a.

❗ Current head 965f566 differs from pull request most recent head eb8cc84. Consider uploading reports for the commit eb8cc84 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3142     +/-   ##
=========================================
+ Coverage    70.9%    72.6%   +1.6%     
=========================================
  Files        1098     1099      +1     
  Lines      102237   103350   +1113     
=========================================
+ Hits        72586    75102   +2516     
+ Misses      24495    23138   -1357     
+ Partials     5156     5110     -46     
Flag Coverage Δ
aggregator 76.8% <0.0%> (+<0.1%) ⬆️
cluster 84.9% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 78.9% <0.0%> (+3.3%) ⬆️
m3em 74.4% <0.0%> (ø)
m3ninx 73.5% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.6% <0.0%> (ø)
query 68.3% <0.0%> (+1.3%) ⬆️
x 80.6% <0.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df132f...eb8cc84. Read the comment docs.

@robskillington robskillington enabled auto-merge (squash) March 17, 2021 20:58
@robskillington robskillington merged commit be8f4f6 into master Mar 18, 2021
@robskillington robskillington deleted the r/fix-as-percent branch March 18, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants