Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move instrumentation cleanup to FetchTaggedResultIterator Close() #3173

Merged
merged 5 commits into from
Feb 5, 2021
Merged

Move instrumentation cleanup to FetchTaggedResultIterator Close() #3173

merged 5 commits into from
Feb 5, 2021

Commits on Feb 4, 2021

  1. Move instrumentation cleanup to FetchTaggedResultIterator Close() 

    This ensures the code paths for FetchTagged and FetchTaggedIterator both
properly run the instrumentation cleanup (updating metrics, spans)
    @ryanhall07
    ryanhall07 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b802282 View commit details
    Browse the repository at this point in the history

  2. Bug fix: close if failed to build iter

    @ryanhall07
    ryanhall07 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    746e8c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Merge branch 'master' into rhall-share-closing

    @ryanhall07
    ryanhall07 authored Feb 5, 2021
    Configuration menu
    Copy the full SHA
    de56c0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rhall-share-closing

    @ryanhall07
    ryanhall07 authored Feb 5, 2021
    Configuration menu
    Copy the full SHA
    ecd8dc1 View commit details
    Browse the repository at this point in the history

  3. lint

    @ryanhall07
    ryanhall07 committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    747e0db View commit details
    Browse the repository at this point in the history