Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Fix Graphite hitcount function by adding support for alignToInterval #3521

Merged
merged 6 commits into from
Jul 11, 2021

Conversation

yyin-sc
Copy link
Collaborator

@yyin-sc yyin-sc commented May 26, 2021

What this PR does / why we need it:

Update hitcount to support alignToInterval

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@yyin-sc yyin-sc marked this pull request as draft May 26, 2021 06:31
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington changed the title [query] [WIP] Update hitcount to support alignToInterval (needs to fix tests) [query] Update hitcount to support alignToInterval Jul 10, 2021
@robskillington robskillington changed the title [query] Update hitcount to support alignToInterval [query] Fix Graphite hitcount function by adding support for alignToInterval Jul 10, 2021
@robskillington robskillington marked this pull request as ready for review July 10, 2021 23:48
@robskillington robskillington enabled auto-merge (squash) July 10, 2021 23:49
@robskillington robskillington merged commit 07ec4e4 into m3db:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants